refactor: name the Gitea protocol re-export #22

Merged

day01 merged %!d() commits from %!s() into %!s()

2026-08-03 13:51:59 +00:00

day01 commented

2026-08-03 13:50:43 +00:00

Owner

Closes #21.

src/lib.rs re-exported one adapter under a vendor-neutral name:

pub use syncode_runner_control_gitea::protocol;

Every other re-export in that file names what it is — engine, source_git,
github_actions. This one promised a neutrality the module does not have: it is
the Gitea Connect family, and src/cli/control.rs maps SynCode, Gitea and
Forgejo onto GiteaFamily while rejecting GitHub and GitLab explicitly.

The name is now gitea_protocol, and the ten call sites in src/cli* and
tests/ follow. Nothing else changes: no types, no behaviour, no public
surface beyond the module path.

Doing it now costs a rename. After a second control-plane adapter lands,
crate::protocol could not mean both, so it would cost a rename plus a
migration of whatever had grown on the ambiguous name in the meantime.

Ran locally: cargo fmt --check, cargo clippy --workspace --all-targets --all-features -- -D warnings, scripts/check-architecture.sh,
scripts/check-rust-loc.sh. The test suite runs in the validation stage of the
image build.

Closes #21. `src/lib.rs` re-exported one adapter under a vendor-neutral name: pub use syncode_runner_control_gitea::protocol; Every other re-export in that file names what it is — `engine`, `source_git`, `github_actions`. This one promised a neutrality the module does not have: it is the Gitea Connect family, and `src/cli/control.rs` maps SynCode, Gitea and Forgejo onto `GiteaFamily` while rejecting GitHub and GitLab explicitly. The name is now `gitea_protocol`, and the ten call sites in `src/cli*` and `tests/` follow. Nothing else changes: no types, no behaviour, no public surface beyond the module path. Doing it now costs a rename. After a second control-plane adapter lands, `crate::protocol` could not mean both, so it would cost a rename plus a migration of whatever had grown on the ambiguous name in the meantime. Ran locally: `cargo fmt --check`, `cargo clippy --workspace --all-targets --all-features -- -D warnings`, `scripts/check-architecture.sh`, `scripts/check-rust-loc.sh`. The test suite runs in the validation stage of the image build.

day01 added 1 commit 2026-08-03 13:50:44 +00:00

refactor: name the Gitea protocol re-export

		`crate::protocol` promised a neutrality the module does not have: it is the
Gitea Connect family, and the CLI maps only SynCode, Gitea and Forgejo onto it
while rejecting GitHub and GitLab. Every other re-export in lib.rs names what it
is.

Renaming now is a rename. After a second control-plane adapter it would also be
a migration of whatever grew on the ambiguous name.

day01 merged commit a1cbc8ee36 into %!s()

2026-08-03 13:51:59 +00:00

day01 deleted branch refactor/name-the-gitea-protocol

2026-08-03 13:52:04 +00:00

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: syncode/runner#22